Conversation
Now, it can be build with maven, we can debug using "yarn debug" Updated readme
arcuri82
requested changes
May 19, 2025
| @@ -0,0 +1,146 @@ | |||
| import {render, waitFor, screen, act, fireEvent} from '@testing-library/react'; | |||
Contributor
There was a problem hiding this comment.
I would refactor the location of this folder. we have src for all files, and src/tests just for this specific test setup? maybe better to have src and src-e2e as siblings, or src/app and src/e2e
| yarn dev | ||
| ``` | ||
|
|
||
| The development server will start at `http://localhost:5173` by default. |
Contributor
There was a problem hiding this comment.
any specific reason for such odd 5173 number? why not 8080 (standard in Java)? or 3000 (standard in nodejs)?
arcuri82
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.